[AI Generated] BugFix: Surface real mismatch reasons for zero-quota VMs instead of unknown reason#4424
Open
johnsongeorge-w wants to merge 1 commit intomainfrom
Open
Conversation
Collaborator
Author
Validation Results
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Azure VM capability selection error reporting in LISA by surfacing meaningful requirement mismatch reasons when all candidate VM sizes are filtered out due to zero quota (limit=0) before capability matching can run.
Changes:
- Preserve a pre–quota-filtered candidate list so requirement checks can still be performed when quota filtering removes all candidates.
- Add a fallback capability-check pass to populate unmet requirement reasons (e.g., architecture mismatch) instead of returning an “unknown reason” skip.
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
johnsongeorge-w
force-pushed
the
bugfix/zero-quota-skip-reason_160426_153253
branch
from
49c1584 to
58362db
Compare
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
…Ms instead of unknown reason
johnsongeorge-w
force-pushed
the
bugfix/zero-quota-skip-reason_160426_153253
branch
from
58362db to
c31f18c
Compare
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When all candidate VMs are dropped due to zero quota before capability matching runs, LISA shows a generic 'unknown reason' skip message instead of the actual mismatch reason (e.g., architecture mismatch). This fix adds a fallback capability check against the full pre-quota-filtered candidate list to surface the real mismatch reasons.
Validation Results